This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Split up the DiagnosticCollections per tool type - #2109
Merged
Ramya Rao (ramya-rao-a) merged 6 commits intoNov 13, 2018
Merged
Conversation
Also set setting diagnostic.source Fixes microsoft#2100, fixes microsoft#2101
Ramya Rao (ramya-rao-a)
approved these changes
Nov 12, 2018
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
Contributor
There was a problem hiding this comment.
Changes look good Segev Finer (@segevfiner)
I have pushed a commit to refactor the de-dupe logic in handleDiagnosticErrors, do take a look.
Segev Finer (segevfiner)
left a comment
Segev Finer (segevfiner)
left a comment
Contributor
Author
There was a problem hiding this comment.
I have pushed a commit to refactor the de-dupe logic in handleDiagnosticErrors, do take a look.
I actually thought about doing that myself when touching that code. 😊 Seems to be working fine.
| }); | ||
| } | ||
|
|
||
| function deDupeDiagnostics(buildDiagnostics: vscode.Diagnostic[], otherDiagnostics: vscode.Diagnostic[]): vscode.Diagnostic[] { |
Contributor
Author
There was a problem hiding this comment.
This function is really more generic than just for the buildDiagnostics. Might be a bit hard to come up with good "generic" names for the parameters though 😛
Segev Finer (segevfiner)
deleted the
rearrange-diagnostic-collections
branch
November 13, 2018 05:46
This was referenced Mar 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code seems quite sensitive, this needs a careful review & some testing. Please pay extra attention to the diagnostic de-duping code in
handleDiagnosticErrors.Fixes #2100, fixes #2101