This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Make iferr and forr snippets a bit more convenient. - #1924
Merged
Conversation
| "for range statement": { | ||
| "prefix": "forr", | ||
| "body": "for ${1:var} := range ${2:var} {\n\t$0\n}", | ||
| "body": "for ${1:_, }${2:var} := range ${3:var} {\n\t$0\n}", |
Contributor
There was a problem hiding this comment.
Since we always need 2 variables, one to hold the index, the other for the element shouldnt the comma be outside the placeholder?
Contributor
There was a problem hiding this comment.
Like {1:_},
Contributor
Author
There was a problem hiding this comment.
The rationale for this is that:
- I'd say in ~90% of cases you're iterating over slice values and you don't care about the first value, so you just tab through.
- When you need to iterate over map keys, or channels, you can just press
<backspace>to delete the whole first placeholder. If the comma is outside, you'd need to delete two things - the placeholder and the comma. - For the final case where you want to keep the key, you just type the name and one extra character (
,).
That said, if you're unconvinced by my reasoning, I'm happy to change it :)
Contributor
There was a problem hiding this comment.
Ah, good point
Ramya Rao (ramya-rao-a)
suggested changes
Sep 11, 2018
Ramya Rao (ramya-rao-a)
left a comment
Ramya Rao (ramya-rao-a)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR Alec Thomas (@alecthomas), I've left just 1 comment. Please do take a look
Ramya Rao (ramya-rao-a)
approved these changes
Sep 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1920.