Move to DocumentSymbol - #1795
Conversation
Jackson Kearl (JacksonKearl)
changed the title
d711046 to
dfc1682
Compare
3c71098 to
fde1159
Compare
fde1159 to
6c67109
Compare
|
Jackson Kearl (@JacksonKearl) I hope you don't mind I updated the PR to the latest master and refactored it a little |
|
Jackson Kearl (@JacksonKearl) , Ramya Rao (@ramya-rao-a) , Joel Hendrix (@jhendrixMSFT) if you can have a look since its a change that touches multiple parts. Still testing all the functionality touched. will update when im done |
1ebdc18 to
6e3393c
Compare
| let symbolInfo = new vscode.SymbolInformation( | ||
| const symbolInfo = new vscode.DocumentSymbol( | ||
| label, | ||
| decl.type, |
There was a problem hiding this comment.
Is this the "details" that is shown next to the symbol in the outline feature?
There was a problem hiding this comment.
yes ( so in this case would look like the name and next to it the type ( e.g. package, function etc)
There was a problem hiding this comment.
also looking in go-outline, everything seems fine, but we stop only at the function level. do we own https://github.com/lukehoban/go-outline ? seems we could get more from the AST
There was a problem hiding this comment.
We own the fork of it https://github.com/ramya-rao-a/go-outline
Feel free to look into that for improvements
There was a problem hiding this comment.
well it seems we might be able to get more info from the AST, of things inside the functions, Joel Hendrix (@jhendrixMSFT) has more experience with the Go AST, he can confirm.
There was a problem hiding this comment.
Absolutely. I've opened #2370 to track enhancing the outline view.
33d9d34 to
e9ebecd
Compare
e9ebecd to
aba4a83
Compare
|
Ramya Rao (@ramya-rao-a) Joel Hendrix (@jhendrixMSFT) Jackson Kearl (@JacksonKearl) everything touched seemed fine on testing, so if you want to double check, otherwise from my side I think its good to go. |
4 participants
this closes #1772