This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Fix prevention of completion popup in line comments. (fixes #1659) - #1671
Merged
Conversation
Ramya Rao (ramya-rao-a)
suggested changes
May 12, 2018
|
|
||
| if (lineText.match(/^\s*\/\//)) { | ||
| // prevent completion when typing in a line comment | ||
| const commentMatch = lineText.match(/\/\/.*$/); |
Contributor
There was a problem hiding this comment.
why not just find the index directly using lineText.indexOf('//') ?
Contributor
Author
There was a problem hiding this comment.
.... That's a very good point. :)
| if (lineText.match(/^\s*\/\//)) { | ||
| // prevent completion when typing in a line comment | ||
| const commentIndex = lineText.indexOf('//'); | ||
| if (commentIndex > 0 && position.character > commentIndex) { |
Contributor
There was a problem hiding this comment.
commentIndex being 0 is valid. This check should be commentIndex > -1
Contributor
Author
There was a problem hiding this comment.
Thanks, good catch!
Ramya Rao (ramya-rao-a)
approved these changes
May 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1659 by checking for a line comment at the end of the current line and also checking that the cursor position is within the line comment.