Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Add the output option for the delve - #1564

Merged
Ramya Rao (ramya-rao-a) merged 2 commits into
microsoft:masterfrom
trknhr:Add-output-args-to-delve
Mar 18, 2018
Merged

Add the output option for the delve#1564
Ramya Rao (ramya-rao-a) merged 2 commits into
microsoft:masterfrom
trknhr:Add-output-args-to-delve

Conversation

@trknhr

@trknhr Teruo Kunihiro (trknhr) commented Mar 7, 2018

Copy link
Copy Markdown
Contributor

Hi

I added the output option for delve.
You would be able to use delve, even if there has been debug directory already.

Thank you

@ramya-rao-a

Copy link
Copy Markdown
Contributor

@1984weed I dont see the --output option when running dlv -h on version "1.0.0-rc.2". Is this available only on a newer version?

@trknhr

Copy link
Copy Markdown
Contributor Author

@ramya-rao-a

Copy link
Copy Markdown
Contributor

You will need to add the output entry at https://github.com/Microsoft/vscode-go/blob/master/package.json#L319 as well, else you won't get a default or intellisense when editing the launch.json file

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Mar 16, 2018

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@ramya-rao-a

Copy link
Copy Markdown
Contributor

@1984weed Can you sign the CLA?

@trknhr

Copy link
Copy Markdown
Contributor Author

Done !!

@ramya-rao-a
Ramya Rao (ramya-rao-a) merged commit 3a1067c into microsoft:master Mar 18, 2018
@ramya-rao-a

Copy link
Copy Markdown
Contributor

@1984weed This feature is now available in the latest update (0.6.78) to the Go extension. Thanks for the PR!

Comment thread package.json
},
"output": {
"type": "string",
"description": "Output path for the bynary of delve",

@levrik Levin Rickert (levrik) Apr 9, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo bynary -> binary

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fixed in master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants