Cursor jump unexpectedly

[maxint64]

After the latest update of vscode-go, I found my cursor would move unexpectedly, the cursor might jump to end of line or bottom of file suddenly when I'm coding. I use vscode-go and vscode-vim together, and the problem appears more frequently when I move cursor past a bracket (including (), {}, []).
I guess there may be something conflict. I close vscode-vim and open vscode-go, cursor move unexpectedly yet. When I close vscode-go and keep using vscode-vim, everything is ok. It's very strange.
Thank you for any suggestion!

[zhao-kun]

I have the same issue as you, I also used vscode-go and vscode-vim. But when I modified the user settings "files.autoSave": "off", the problem was solved.

[maxint64]

Kun Zhao (@zhao-kun) Thank you very much!

[ramya-rao-a]

This is weird. The only thing happening on save that can move stuff around is the formatting feature.

I can repro the case when the cursor moves to the next line, but not the case when the cursor moving to the bottom of the file.

Can either of you provide a small sample code with repro steps for when you see the cursor going to the end of the file?

[ramya-rao-a]

I have pushed the fix for the issue that I see i.e cursor jumping to the next line.

Can either of you test it and see if it solves your case as well? All you have to do is

• Download https://github.com/Microsoft/vscode-go/blob/master/Go-latest.vsix
• Run code --install-extension Go-latest.vsix and reload VS Code

[ramya-rao-a]

Scratch that.

I can repro the case when the cursor jumps to the last line.
It is when the changes due to formatting spans multiple lines till the end of the document.

The root cause is due to changes in the core api. I'll dig around a little more and get back here.

[maxint64]

Ramya Rao (@ramya-rao-a) I tried your extension but the problem still exists. I did more test and found cursor will certainly jump to end of file after saving, no matter which way I use (click save button, press ctrl+s, or use vim command :w)

[ramya-rao-a]

maxint64 Thanks. I found today that the root cause is with the way edits are applied by VS Code. Something changed between VS code 1.17 and 1.18 release.
I have logged an upstream issue for this. microsoft/vscode#38728
We should be able to get a fix in the Insiders soon.

Until then, the work around is to either disable the format on save feature or the auto save feature.
There is no fix to be done from the Go extension's side

[Xjs]

Ramya Rao (@ramya-rao-a) Just a quick hint that after your changes introduced in 89e1a18 the curser no longer moves to the end but to the beginning of the file when formatting-on-save.

[ramya-rao-a]

Jannis Andrija Schnitzer (@Xjs) I know... Its a temporary fix. I figured cursor moving to start of the same line is a just a little bit less annoying than it moving to the end of the file.

Previously, the edits being applied were multi line edits
Right now the edits being applied are single line

The right fix would require us to apply edits only for the part of the line that needs the change which is slightly more complicated as the Go tools only return diffs at line level