Function complete doesn't support inline functions

[FiloSottile]

If a local variable like this is defined

ensureKeyword := func (k string) {}

then ensureKeyword autocompletes to ensureKeyword without arguments even if useCodeSnippetsOnFunctionSuggestWithoutType is true.

[alexkohler]

It looks like we are checking if the suggest.class is 'func', whereas we should
be checking if the suggest.type contains 'func' (because a locally defined function will have a class of 'var', not func). https://github.com/Microsoft/vscode-go/blob/0.6.66/src/goSuggest.ts#L168

I.e. before:
...&& suggest.class === 'func'

My proposed solution:
...&& suggest.type.includes('func')

Ramya Rao (@ramya-rao-a) thoughts?

[ramya-rao-a]

In this case what does suggest.type have?

[alexkohler]

Ramya Rao (@ramya-rao-a) The suggest.type would be func (k string) I think - I’ll double check this when I have access to my PC.

[alexkohler]

Ramya Rao (@ramya-rao-a) Yes, to confirm the suggest.type is func(k string). The suggest.type of the same function declared non-locally is also func(k string). Looking at all the potential edge cases, using includes does seem a little heavy handed.

[ramya-rao-a]

by non-locally, you mean in another file in the same package?

[alexkohler]

Not necessarily in another file, just declared in package scope rather than local scope.

I.e.:

package main

// package scoped function p
func p (k string) {}

func main() {
// locally scoped function l
l := func (k string) {}
}

[ramya-rao-a]

The suggest.type of the same function declared non-locally is also func(k string)

Wouldn't the non-locally declared function have the class as func?

So && suggest.class === 'func' could be replaced with && (suggest.class === 'func' || (suggest.class === 'var' && suggest.type.startswith('func')))

[ramya-rao-a]

This feature is now out in the latest update to the Go extension (0.6.80)