From 90ed806a3fc1b42e81ca587233970ae0c8a2c5a7 Mon Sep 17 00:00:00 2001 From: Gyuheon Oh Date: Tue, 21 Apr 2026 09:07:36 -0400 Subject: [PATCH 1/2] Default errors intake to be on --- .../src/crash_info/errors_intake.rs | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/libdd-crashtracker/src/crash_info/errors_intake.rs b/libdd-crashtracker/src/crash_info/errors_intake.rs index 2d147fe64a..1b5777db93 100644 --- a/libdd-crashtracker/src/crash_info/errors_intake.rs +++ b/libdd-crashtracker/src/crash_info/errors_intake.rs @@ -111,7 +111,7 @@ impl ErrorsIntakeSettings { errors_intake_dd_url: parse_env::str_not_empty(Self::DD_ERRORS_INTAKE_DD_URL), shared_lib_debug: parse_env::bool(Self::_DD_SHARED_LIB_DEBUG).unwrap_or(false), errors_intake_enabled: parse_env::bool(Self::DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED) - .unwrap_or(false), + .unwrap_or(true), agent_uds_socket_found: (|| { #[cfg(unix)] @@ -883,31 +883,22 @@ mod tests { } #[test] - fn test_errors_intake_enabled_flag() { + fn test_errors_intake_disabled_flag() { let _lock = ENV_TEST_LOCK.lock().unwrap_or_else(|e| e.into_inner()); - // Test default behavior (should be enabled) clear_errors_intake_env(); - let cfg = ErrorsIntakeConfig::from_env(); - assert!(!cfg.is_errors_intake_enabled()); - // Test explicitly enabled - std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "true"); + // Default behavior is enabled let cfg = ErrorsIntakeConfig::from_env(); assert!(cfg.is_errors_intake_enabled()); - // Test explicitly disabled - std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "false"); - let cfg = ErrorsIntakeConfig::from_env(); - assert!(!cfg.is_errors_intake_enabled()); - // Test with uploader let uploader = ErrorsIntakeUploader::new(&None).unwrap(); - assert!(!uploader.is_enabled()); + assert!(uploader.is_enabled()); - std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "true"); + std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "false"); let uploader = ErrorsIntakeUploader::new(&None).unwrap(); - assert!(uploader.is_enabled()); + assert!(!uploader.is_enabled()); } #[test] From f1c6a0fa2e0fe207d08aa8542a924deded01349c Mon Sep 17 00:00:00 2001 From: Gyuheon Oh Date: Tue, 21 Apr 2026 10:06:32 -0400 Subject: [PATCH 2/2] Trigger ci