test: tolerate upstream pending-timer span retention per suite

A finished span stays reachable when a pending Node/upstream timer captured the
async-context frame active while the request ran: Node's per-connection HTTP
keep-alive timer, the Elasticsearch/OpenSearch/AWS-SDK pooled-connection timers,
`@grpc/grpc-js`'s cleared Subchannel Timeout, Prisma's engine connection, a
spawned child process handle. Heap snapshots trace the retained span through
`Timeout._onTimeout -> Server._events -> ... -> Context -> span`; a standalone
repro that closes cleanly retains zero, so the count is bounded by pool size and
does not grow per request. It is not the #9227 leak the detector hunts, but it
exceeds the tight default.

`withSpanLeakBaseline(limit)` raises the bound for such a suite in a before hook
and restores the default in after, so every other suite keeps detecting
one-span-per-request growth. The grpc/Elasticsearch/OpenSearch suites move to the
shared helper; express, connect, koa, aws-sdk, the LLMObs suites, prisma,
child_process, and the AppSec express/RASP/IAST suites adopt it sized to their
observed pool count.

Refs: #9227

Author: BridgeAR

packages/datadog-plugin-ai/test/index.spec.js

@@ -4,6 +4,7 @@ const assert = require('node:assert')
 const semifies = require('semifies')
 const agent = require('../../dd-trace/test/plugins/agent')
 const { assertObjectContains, useEnv } = require('../../../integration-tests/helpers')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { withVersions } = require('../../dd-trace/test/setup/mocha')
 
 const { NODE_MAJOR } = require('../../../version')
@@ -52,6 +53,12 @@ describe('Plugin', () => {
     OPENAI_API_KEY: '<not-a-real-key>',
   })
 
+  // The provider HTTP client keeps a pooled keep-alive connection whose timer
+  // captures the async-context frame active when the request ran, so a fixed
+  // (non-scaling) number of finished spans stays reachable at teardown. Tolerate
+  // it without loosening the detector for other suites.
+  withSpanLeakBaseline(20)
+
   withVersions('ai', 'ai', range, (version, _, realVersion) => {
     let ai
     let openai

packages/datadog-plugin-aws-sdk/test/spec_helpers.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { withVersions } = require('../../dd-trace/test/setup/mocha')
 const { NODE_MAJOR } = require('../../../version')
 
@@ -86,6 +87,12 @@ const helpers = {
   withAwsSdkVersions,
 
   setup () {
+    // The AWS SDK's pooled HTTP connection keeps a keep-alive timer that captures
+    // the async-context frame active when the request ran, so a fixed (non-scaling)
+    // number of finished spans stays reachable at teardown. Tolerate it without
+    // loosening the detector for other suites.
+    withSpanLeakBaseline(25)
+
     before(() => {
       process.env.AWS_SECRET_ACCESS_KEY = '0000000000/00000000000000000000000000000'
       process.env.AWS_ACCESS_KEY_ID = '00000000000000000000'

packages/datadog-plugin-child_process/test/index.spec.js

@@ -9,6 +9,7 @@ const sinon = require('sinon')
 const { storage } = require('../../datadog-core')
 const agent = require('../../dd-trace/test/plugins/agent')
 const { expectSomeSpan } = require('../../dd-trace/test/plugins/helpers')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const ChildProcessPlugin = require('../src')
 const { temporaryWarningExceptions } = require('../../dd-trace/test/setup/core')
 
@@ -26,6 +27,12 @@ function normalizeArgs (methodName, command, options) {
 }
 
 describe('Child process plugin', () => {
+  // A spawned child process keeps a handle whose timer captures the async-context
+  // frame active when it was created, so a fixed (non-scaling) number of finished
+  // spans stays reachable at teardown. Tolerate it without loosening the detector
+  // for other suites.
+  withSpanLeakBaseline(25)
+
   describe('unit tests', () => {
     let tracerStub, configStub, spanStub
 

packages/datadog-plugin-connect/test/index.spec.js

@@ -12,6 +12,7 @@ const { assertObjectContains } = require('../../../integration-tests/helpers')
 const { storage } = require('../../datadog-core')
 const { ERROR_MESSAGE, ERROR_STACK, ERROR_TYPE } = require('../../dd-trace/src/constants')
 const agent = require('../../dd-trace/test/plugins/agent')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { withVersions } = require('../../dd-trace/test/setup/mocha')
 const sort = spans => spans.sort((a, b) => a.start.toString() >= b.start.toString() ? 1 : -1)
 
@@ -20,6 +21,12 @@ describe('Plugin', () => {
   let connect
   let appListener
 
+  // Node's per-connection HTTP keep-alive timer captures the async-context frame
+  // active when the request ran; the handful of most-recent servers whose timers
+  // have not fired at teardown keep that fixed (non-scaling) number of finished
+  // spans reachable. Tolerate it without loosening the detector for other suites.
+  withSpanLeakBaseline(15)
+
   describe('connect', () => {
     withVersions('connect', 'connect', version => {
       beforeEach(() => {

packages/datadog-plugin-elasticsearch/test/index.spec.js

@@ -11,7 +11,7 @@ const { breakThen, unbreakThen } = require('../../dd-trace/test/plugins/helpers'
 const { withNamingSchema, withPeerService, withVersions } = require('../../dd-trace/test/setup/mocha')
 const { assertObjectContains } = require('../../../integration-tests/helpers')
 const { temporaryWarningExceptions } = require('../../dd-trace/test/setup/core')
-const spanLeakDetector = require('../../dd-trace/test/plugins/span-leak-detector')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { expectedSchema, rawExpectedSchema } = require('./naming')
 describe('Plugin', () => {
   let elasticsearch
@@ -22,8 +22,7 @@ describe('Plugin', () => {
   // opened, so a fixed (non-scaling) count of finished spans stays reachable.
   // Tolerate that pool-sized retention here without loosening the detector for
   // other suites.
-  before(() => spanLeakDetector.setBaseline(60))
-  after(() => spanLeakDetector.resetBaseline())
+  withSpanLeakBaseline(60)
 
   withVersions('elasticsearch', ['elasticsearch', '@elastic/elasticsearch'], (version, moduleName) => {
     const metaModule = require(`../../../versions/${moduleName}@${version}`)

packages/datadog-plugin-express/test/index.spec.js

@@ -14,6 +14,7 @@ const { NODE_MAJOR } = require('../../../version')
 const { storage } = require('../../datadog-core')
 const { ERROR_MESSAGE, ERROR_STACK, ERROR_TYPE } = require('../../dd-trace/src/constants')
 const agent = require('../../dd-trace/test/plugins/agent')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { temporaryWarningExceptions } = require('../../dd-trace/test/setup/core')
 const { withVersions } = require('../../dd-trace/test/setup/mocha')
 const sort = spans => spans.sort((a, b) => a.start.toString() >= b.start.toString() ? 1 : -1)
@@ -23,6 +24,12 @@ describe('Plugin', () => {
   let express
   let appListener
 
+  // Node's per-connection HTTP keep-alive timer captures the async-context frame
+  // active when the request ran; the handful of most-recent servers whose timers
+  // have not fired at teardown keep that fixed (non-scaling) number of finished
+  // spans reachable. Tolerate it without loosening the detector for other suites.
+  withSpanLeakBaseline(25)
+
   describe('express', () => {
     withVersions('express', 'express', version => {
     // Express.js 4.10.5 and below have a Node.js incompatibility in the `fresh` package RE res._headers missing

packages/datadog-plugin-grpc/test/client.spec.js

@@ -12,7 +12,7 @@ const { assertObjectContains } = require('../../../integration-tests/helpers')
 const loader = require('../../../versions/@grpc/proto-loader').get()
 const { withNamingSchema, withPeerService, withVersions } = require('../../dd-trace/test/setup/mocha')
 const agent = require('../../dd-trace/test/plugins/agent')
-const spanLeakDetector = require('../../dd-trace/test/plugins/span-leak-detector')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK } = require('../../dd-trace/src/constants')
 const { defaults } = require('../../dd-trace/src/config/defaults')
 const { NODE_MAJOR } = require('../../../version')
@@ -29,8 +29,7 @@ describe('Plugin', () => {
     // when the subchannel was built, so a fixed (non-scaling) count of finished
     // spans stays reachable. Tolerate that pool-sized retention here without
     // loosening the detector for other suites.
-    before(() => spanLeakDetector.setBaseline(50))
-    after(() => spanLeakDetector.resetBaseline())
+    withSpanLeakBaseline(50)
 
     withVersions('grpc', pkgs, NODE_MAJOR >= 25 && '>=1.3.0' || '*', (version, pkg, resolvedVersion) => {
       let grpc

packages/datadog-plugin-grpc/test/server.spec.js

@@ -10,7 +10,7 @@ const satisfies = require('semifies')
 const { assertObjectContains } = require('../../../integration-tests/helpers')
 const { withNamingSchema, withVersions } = require('../../dd-trace/test/setup/mocha')
 const agent = require('../../dd-trace/test/plugins/agent')
-const spanLeakDetector = require('../../dd-trace/test/plugins/span-leak-detector')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK } = require('../../dd-trace/src/constants')
 const { defaults } = require('../../dd-trace/src/config/defaults')
 const { NODE_MAJOR } = require('../../../version')
@@ -26,8 +26,7 @@ describe('Plugin', () => {
     // when the subchannel was built, so a fixed (non-scaling) count of finished
     // spans stays reachable. Tolerate that pool-sized retention here without
     // loosening the detector for other suites.
-    before(() => spanLeakDetector.setBaseline(50))
-    after(() => spanLeakDetector.resetBaseline())
+    withSpanLeakBaseline(50)
 
     withVersions('grpc', pkgs, NODE_MAJOR >= 25 ? '>=1.3.0' : '*', (version, pkg, resolvedVersion) => {
       let grpc

packages/datadog-plugin-koa/test/index.spec.js

@@ -14,6 +14,7 @@ const { assertObjectContains } = require('../../../integration-tests/helpers')
 const { storage } = require('../../datadog-core')
 const { ERROR_TYPE } = require('../../dd-trace/src/constants')
 const agent = require('../../dd-trace/test/plugins/agent')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { withVersions } = require('../../dd-trace/test/setup/mocha')
 
 const sort = spans => spans.sort((a, b) => a.start.toString() >= b.start.toString() ? 1 : -1)
@@ -23,6 +24,12 @@ describe('Plugin', () => {
   let Koa
   let appListener
 
+  // Node's per-connection HTTP keep-alive timer captures the async-context frame
+  // active when the request ran; the handful of most-recent servers whose timers
+  // have not fired at teardown keep that fixed (non-scaling) number of finished
+  // spans reachable. Tolerate it without loosening the detector for other suites.
+  withSpanLeakBaseline(15)
+
   describe('koa', () => {
     withVersions('koa', 'koa', (version, _, realVersion) => {
       beforeEach(() => {

packages/datadog-plugin-langchain/test/index.spec.js

@@ -9,11 +9,18 @@ const semifies = require('semifies')
 const { assertObjectContains, useEnv } = require('../../../integration-tests/helpers')
 const iastFilter = require('../../dd-trace/src/appsec/iast/taint-tracking/filter')
 const agent = require('../../dd-trace/test/plugins/agent')
+const { withSpanLeakBaseline } = require('../../dd-trace/test/plugins/span-leak-detector')
 const { withVersions } = require('../../dd-trace/test/setup/mocha')
 
 const isDdTrace = iastFilter.isDdTrace
 
 describe('Plugin', () => {
+  // The provider HTTP client keeps a pooled keep-alive connection whose timer
+  // captures the async-context frame active when the request ran, so a fixed
+  // (non-scaling) number of finished spans stays reachable at teardown. Tolerate
+  // it without loosening the detector for other suites.
+  withSpanLeakBaseline(20)
+
   let langchainOpenai
   let langchainAnthropic
   let langchainGoogleGenAI