Repository navigation
Commit d780ab0
fix(ci): stop the Node 24.21 healthcheck hang and cap job runtimes (#267)
## Summary
The **Node 24** CI job hangs on every PR until GitHub's 6-hour limit.
`node-version: "24"` now resolves to **v24.21.0**, whose `node:http2`
client defers `RST_STREAM` while receiving (nodejs/node#65093, a
v24-only adaptation of #64166). A stream closed with `req.close()` from
its `'response'` handler before its body is read is never destroyed, so
the client keeps its TCP connection open. The healthcheck test helper
`httpStatus` uses exactly that pattern. As a result, the server's
graceful `stop()` never completes and the integration suite never exits.
The regression was reproduced on plain `node:http2` without Connectum:
24.20.0 exits, 24.21.0 hangs, 26.10.0 exits. It is a client-side issue;
the server's Node version is irrelevant.
- **Test.** `worker-components.test.ts` `httpStatus` drains the response
body before closing the session.
- **CI.** Every workflow job gets `timeout-minutes`: 15, and 30 for
"Release & Publish". The slowest job over 224 successful runs took 116
s, so a hang now fails in minutes instead of hours.
A related server-side reliability gap is **not** addressed here and will
get its own PR: after `shutdown.timeout`, Connectum destroys HTTP/2
sessions but not raw sockets, so the process does not exit while a
client holds TCP.
## Type of change
- [ ] Bug fix (non-breaking)
- [ ] New feature (non-breaking)
- [ ] Breaking change (documented in migration guide)
- [x] Documentation / chore / internal
## Test plan
- [x] healthcheck integration suite in Docker: 16/16 with exit in about
1 s on `node:24.20.0`, `node:24.21.0` and `node:26.10.0`. Before the
fix, 24.21.0 hung.
- [x] `pnpm build && pnpm typecheck && pnpm test` pass locally (33/33
turbo tasks)
- [x] `pnpm lint` passes locally. The only warning,
`packages/events/src/broadcast.ts:18`, pre-exists on `main`.
- [x] `pnpm release:contract` passes (`release.yml` gains only
`timeout-minutes`)
- [x] Every job has `timeout-minutes`, checked with `yq` over all 10
workflow files.
- [ ] CI "Node 24" green on this PR is the end-to-end check.
## Parity coverage
- [ ] Parity coverage added
- [x] Parity N/A: test helper and CI configuration only, no RPC
behaviour changes.
## Related issues / changes
- Upstream: nodejs/node#65093 / #64166 (v24.21.0).
- Unblocks the Node 24 job on #265 and future PRs.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Improvements**
* Automated checks and maintenance workflows now have a 15-minute time
limit, and release publishing has a 30-minute limit.
* Health-check integration tests now wait for HTTP/2 responses to finish
before reporting the status.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 937cc0f commit d780ab0
11 files changed
Lines changed: 37 additions & 4 deletions
File tree
- .github/workflows
- packages/healthcheck/tests/integration
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| 89 | + | |
88 | 90 | | |
89 | 91 | | |
90 | 92 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
20 | 23 | | |
| 24 | + | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
| |||
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
| 57 | + | |
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
| |||
83 | 88 | | |
84 | 89 | | |
85 | 90 | | |
| 91 | + | |
86 | 92 | | |
87 | 93 | | |
88 | 94 | | |
| |||
117 | 123 | | |
118 | 124 | | |
119 | 125 | | |
| 126 | + | |
120 | 127 | | |
121 | 128 | | |
122 | 129 | | |
| |||
157 | 164 | | |
158 | 165 | | |
159 | 166 | | |
| 167 | + | |
160 | 168 | | |
161 | 169 | | |
162 | 170 | | |
| |||
191 | 199 | | |
192 | 200 | | |
193 | 201 | | |
| 202 | + | |
194 | 203 | | |
195 | 204 | | |
196 | 205 | | |
| |||
228 | 237 | | |
229 | 238 | | |
230 | 239 | | |
| 240 | + | |
231 | 241 | | |
232 | 242 | | |
233 | 243 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| 41 | + | |
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
| |||
0 commit comments