Skip to content

Commit 657dfdf

Browse files
adrianhallahall
andauthored
fix: remove redundant NU1510 PackageReference pins in TodoApp.Uno (#558)
System.Formats.Asn1, System.Private.Uri, and System.Text.Json were pinned as top-level PackageReference/PackageVersion entries since the Uno sample was first added, but NuGet's package-pruning feature now considers these pins redundant on every head (desktop, browserwasm, windows, android, ios-maccatalyst) - the implicitly-resolved versions already satisfy the pins, so restore emits NU1510 for each. Removed the three redundant entries from Directory.Packages.props and TodoApp.Uno.csproj. System.IO.Packaging (never triggers NU1510) and SQLitePCLRaw.bundle_e_sqlite3 (genuine NU1903 CVE floor, see #492) are left untouched. Verified: dotnet restore/build -f net10.0-desktop now completes with no NU1510 warnings (previously 3) and no new warnings/errors. Other heads (android/ios-maccatalyst/browserwasm/windows) require Uno workloads not available locally; verification for those relies on the todoapp-uno CI matrix. Fixes #540 Co-authored-by: ahall <ahall@cloudflare.com>
1 parent bbc7324 commit 657dfdf

2 files changed

Lines changed: 0 additions & 6 deletions

File tree

samples/todoapp/TodoApp.Uno/Directory.Packages.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
<!-- Force the SQLitePCLRaw 3.x line to resolve NU1903 (GHSA-2m69-gcr7-jv3q) floated by CommunityToolkit.Datasync.Client -> Microsoft.EntityFrameworkCore.Sqlite. See #492. -->
1515
<PackageVersion Include="SQLitePCLRaw.bundle_e_sqlite3" Version="3.0.3" />
1616
<PackageVersion Include="Refit" Version="8.0.0" />
17-
<PackageVersion Include="System.Formats.Asn1" Version="10.0.9" />
1817
<PackageVersion Include="System.IO.Packaging" Version="10.0.9" />
19-
<PackageVersion Include="System.Private.Uri" Version="4.3.2" />
20-
<PackageVersion Include="System.Text.Json" Version="10.0.9" />
2118
</ItemGroup>
2219
</Project>

samples/todoapp/TodoApp.Uno/TodoApp.Uno/TodoApp.Uno.csproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,7 @@
7474
<PackageReference Include="CommunityToolkit.Datasync.Client" />
7575
<!-- Force the SQLitePCLRaw 3.x line to resolve NU1903 (GHSA-2m69-gcr7-jv3q) floated by CommunityToolkit.Datasync.Client -> Microsoft.EntityFrameworkCore.Sqlite. See #492. -->
7676
<PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" />
77-
<PackageReference Include="System.Formats.Asn1" />
7877
<PackageReference Include="System.IO.Packaging" />
79-
<PackageReference Include="System.Private.Uri" />
80-
<PackageReference Include="System.Text.Json" />
8178
</ItemGroup>
8279
<ItemGroup>
8380
<Page Update="Views\TodoListPage.xaml">

0 commit comments

Comments
 (0)