feat(comfy-cli): push prints its save's warnings and holds a release on a model link warning (BE-15875) (#901)

Author: james00012

CHANGELOG.md

@@ -17,6 +17,9 @@ history.
 
 ### Added
 
+- `comfy build push` prints every warning a save returns, and `--release` cuts no
+  release while one says a deployment could not download a model link
+  (`build_release_held`); `--release-despite-warnings` cuts anyway.
 - `comfy build release delete RELEASE` deletes the named release, freeing the slot
   it held against the workspace's release limit. It confirms first (`--yes` skips
   the prompt, `build_release_delete_needs_confirm` refuses a caller that cannot

comfy_cli/builder_api.py

@@ -118,12 +118,13 @@ def upload_blob(self, upload_url: str, path: Path) -> None:
             )
         resp.raise_for_status()
 
-    def create_build(self, name: str, definition: dict, description: str | None = None) -> str:
-        """Create a build from a definition. Returns its id."""
+    def create_build_response(self, name: str, definition: dict, description: str | None = None) -> dict:
+        """Create a build from a definition. Returns the created build, carrying
+        the ``warnings`` the save earned, which a read never returns."""
         body: dict = {"name": name, "definition": definition}
         if description:
             body["description"] = description
-        return self._post(("builds",), body)["id"]
+        return self._post(("builds",), body)
 
     def create_release(self, build_id: str, targets: list[dict] | None = None) -> tuple[str, str]:
         """POST /v1/builds/{id}/releases: freeze the definition and enqueue a

comfy_cli/command/build.py

@@ -1855,6 +1855,13 @@ def push_cmd(
         bool,
         typer.Option("--force", help="Overwrite remote changes, retrying a bounded GET-then-PATCH."),
     ] = False,
+    release_despite_warnings: Annotated[
+        bool,
+        typer.Option(
+            "--release-despite-warnings",
+            help="With --release, cut the release even though the save warned about a model link.",
+        ),
+    ] = False,
     dry_run: Annotated[bool, typer.Option("--dry-run", help="Compute uploads locally; send no HTTP requests.")] = False,
     models_dir: Annotated[
         str | None,
@@ -1875,6 +1882,14 @@ def push_cmd(
             details={"conflict": ["--release", "--dry-run"]},
         )
         raise typer.Exit(code=1)
+    if release_despite_warnings and not release:
+        renderer.error(
+            code="build_missing_input",
+            message="--release-despite-warnings applies only to the release --release cuts.",
+            hint="pass --release to cut a release despite the save's model link warnings",
+            details={"missing": ["--release"]},
+        )
+        raise typer.Exit(code=1)
     targets = _parse_release_targets(renderer, target or ())
     if targets and not release:
         renderer.error(
@@ -1991,8 +2006,14 @@ def push_cmd(
     name = str(spec["name"])
     description = str(spec["description"])
     if target_id is None:
-        target_id = _builder_call(renderer, lambda: client.create_build(name, wire_definition, description))
-        saved = _builder_call(renderer, lambda: client.get_build(target_id))
+        created_build = _builder_call(
+            renderer, lambda: client.create_build_response(name, wire_definition, description)
+        )
+        target_id = created_build["id"]
+        saved = {
+            **_builder_call(renderer, lambda: client.get_build(target_id)),
+            "warnings": created_build.get("warnings"),
+        }
         created = True
     elif force:
         saved = _force_update(renderer, client, target_id, wire_definition, name, description)
@@ -2028,6 +2049,12 @@ def push_cmd(
             "deduped": len(uploads) - uploaded,
         }
     )
+    warnings = _save_warnings(saved)
+    if warnings:
+        payload["warnings"] = warnings
+    _hold_release_on_link_warnings(
+        renderer, warnings, target_id, saved["updatedAt"], release and not release_despite_warnings
+    )
     release_summary: dict[str, str] | None = None
     if release:
         requested = [item.as_wire() for item in targets]
@@ -2050,6 +2077,50 @@ def push_cmd(
     renderer.emit(payload, command="build push", changed=True)
 
 
+# A warning at this field is comfy-builder's for a model link a deployment could
+# not download; it is the whole contract a held release rests on. Any other
+# field, such as pipDependencies, is printed and never holds a release.
+_MODEL_LINK_FIELD = re.compile(r"models\[\d+\]\.sourceUri")
+
+
+def _save_warnings(saved: dict) -> list[dict[str, str]]:
+    """The warnings a save returned, as field and reason, dropping anything the
+    builder sent in another shape rather than failing a push that landed."""
+    raw = saved.get("warnings")
+    if not isinstance(raw, list):
+        return []
+    return [
+        {"field": item["field"], "reason": item["reason"]}
+        for item in raw
+        if isinstance(item, dict) and isinstance(item.get("field"), str) and isinstance(item.get("reason"), str)
+    ]
+
+
+def _hold_release_on_link_warnings(
+    renderer, warnings: list[dict[str, str]], build_id: str, revision: str, cutting: bool
+) -> None:
+    """Print every warning the save returned, and refuse the cut a push asked for
+    while one is about a model link a deployment could not download. The build is
+    already saved and the spec already carries its revision, so a second push with
+    the go-ahead option cuts without saving anything twice."""
+    for warning in warnings:
+        renderer.warn(f"{warning['field']}: {warning['reason']}")
+    held = [warning for warning in warnings if _MODEL_LINK_FIELD.fullmatch(warning["field"])]
+    if not cutting or not held:
+        return
+    details: dict = {"id": build_id, "syncedRevision": revision}
+    # Text mode has already printed each warning above; only JSON carries them again.
+    if not renderer.is_pretty():
+        details["warnings"] = warnings
+    renderer.error(
+        code="build_release_held",
+        message=f"saved build {build_id}, but cut no release: the save warned that a deployment could not "
+        "download " + ", ".join(warning["field"] for warning in held),
+        details=details,
+    )
+    raise typer.Exit(code=1)
+
+
 def _prompt_build_id(renderer, client) -> str | None:
     from comfy_cli.ui import prompt_select
 

comfy_cli/error_codes.py

@@ -1235,6 +1235,13 @@ class ErrorCode:
         "reconstruct every requested public node.",
         "edit the spec to name a published registry version or normalized repository, or remove the node",
     ),
+    ErrorCode(
+        "build_release_held",
+        "`comfy build push --release` saved the build, but the save warned about a model link a deployment "
+        "could not download, so no release was cut. `details` carries the saved `id`, `syncedRevision` and "
+        "every `warnings` entry; a warning at `models[<n>].sourceUri` is the one that holds a release.",
+        "fix the model links and push again, or push with --release --release-despite-warnings to cut anyway",
+    ),
     ErrorCode(
         "build_release_limit",
         "The builder refused the release cut because the workspace already holds as many releases as its "

comfy_cli/schemas/build_push.json

@@ -25,6 +25,20 @@
     "upload_bytes": {"type": "integer", "minimum": 0},
     "uploaded": {"description": "Blobs whose bytes were transferred. Never exceeds `upload_count`: the builder answers with an id it already holds, and no upload URL, when the workspace already stored those exact bytes.", "type": "integer", "minimum": 0},
     "deduped": {"description": "Blobs the builder already held, so `upload_count` was planned but not transferred. Always `upload_count - uploaded`.", "type": "integer", "minimum": 0},
+    "warnings": {
+      "description": "Non-blocking advisories the save returned; present only when it returned at least one. A warning at `models[<n>].sourceUri` names a model link a deployment could not download.",
+      "type": "array",
+      "minItems": 1,
+      "items": {
+        "type": "object",
+        "required": ["field", "reason"],
+        "additionalProperties": false,
+        "properties": {
+          "field": { "type": "string" },
+          "reason": { "type": "string" }
+        }
+      }
+    },
     "skipped_symlinks": {
       "description": "Symlinks excluded from a packaged custom node; present only when packaging skipped at least one. `location` points into the definition of the spec at `spec_file` (this payload carries no definition of its own), `localPath` names the node under custom_nodes/, and `member` is the symlink's path inside that node.",
       "type": "array",

comfy_cli/skills/comfy-build-failures/SKILL.md

@@ -85,6 +85,11 @@ the message names the field:
 - `build_spec_stale` — the remote moved under you, or `--id` names a Build the
   spec's `syncedRevision` does not belong to. See *Revising*.
 
+- **`build_release_held`** — the save warned that a deployment could not download a
+  model link, so the push cut no release. Under `--json`, `details.warnings` names
+  each link and how its host refused; in text mode the tool printed each just above. Fix the link, or ask the user before passing
+  `--release-despite-warnings`.
+
 Two refusals are the workspace being full rather than the definition being wrong,
 and neither is fixed by editing anything:
 

comfy_cli/skills/comfy-build/SKILL.md

@@ -289,6 +289,14 @@ for comes back as a refusal envelope and exits 1: `build_update_needs_confirm`,
 Pass `--yes`, or the option it named, once the user has actually agreed. Do not
 pass `--yes` first and disclose after.
 
+**`build_release_held` asks the same way, with its own option.** `comfy build push
+--release` saved the build but cut no release, because the save warned that a
+deployment could not download a model link. Under `--json` the error carries them
+in `details.warnings`; in text mode the tool printed each just above it. Tell the
+user which links fail and how, and pass `--release-despite-warnings` only after they say
+yes; a fixed link needs no option. `comfy build release create` cuts without this
+check.
+
 **Three other refusals block rather than ask — `--yes` does nothing for them.**
 Each is cleared by deleting something, and each exits 1:
 

tests/comfy_cli/command/build_push_support.py

@@ -24,6 +24,8 @@ def __init__(self) -> None:
         self.revision_number = 0
         self.stale_updates = 0
         self.always_stale = False
+        # What every save answers with under ``warnings``; empty means none.
+        self.save_warnings: list[JsonObject] = []
         self.build_targets: list[JsonObject] = [
             {"target": {"os": "linux", "gpu": "nvidia"}, "label": "Linux NVIDIA", "artifactKind": "image"},
             {"target": {"os": "linux", "gpu": "cpu"}, "label": "Linux CPU", "artifactKind": "image"},
@@ -76,7 +78,7 @@ def upload_blob(self, upload_url: str, path: Path) -> None:
         self.calls.append({"method": "upload_blob", "url": upload_url})
         self.uploaded.append(path.read_bytes())
 
-    def create_build(self, name: str, definition: JsonObject, description: str | None = None) -> str:
+    def create_build_response(self, name: str, definition: JsonObject, description: str | None = None) -> JsonObject:
         revision = self._revision()
         self.remote_revisions[self.created_id] = revision
         self.calls.append(
@@ -88,7 +90,10 @@ def create_build(self, name: str, definition: JsonObject, description: str | Non
                 "definition": definition,
             }
         )
-        return self.created_id
+        created: JsonObject = {"id": self.created_id, "updatedAt": revision}
+        if self.save_warnings:
+            created["warnings"] = self.save_warnings
+        return created
 
     def get_build(self, build_id: str) -> JsonObject:
         revision = self.remote_revisions.setdefault(build_id, self._revision())
@@ -121,7 +126,10 @@ def update_build(
             raise stale_error()
         revision = self._revision()
         self.remote_revisions[build_id] = revision
-        return {"id": build_id, "updatedAt": revision, "name": name, "description": description}
+        updated: JsonObject = {"id": build_id, "updatedAt": revision, "name": name, "description": description}
+        if self.save_warnings:
+            updated["warnings"] = self.save_warnings
+        return updated
 
     def list_build_targets(self) -> list[JsonObject]:
         self.calls.append({"method": "list_build_targets"})

tests/comfy_cli/command/test_build.py

@@ -599,7 +599,7 @@ def fake_request_json(url, target, *, method="GET", body=None, max_bytes, timeou
 
     c = BuilderClient("https://builder.test/", "jwt-token")
     assert c.create_blob("model", "f.safetensors", "hash", 5) == ("b1", "https://put")
-    assert c.create_build("n", {"models": [], "customNodes": []}) == "d1"
+    assert c.create_build_response("n", {"models": [], "customNodes": []})["id"] == "d1"
     assert c.create_release("d1", [{"os": "linux", "gpu": "nvidia"}]) == ("v1", "https://s")
     results = c.resolve_models(["a.safetensors"])
     assert results[0]["candidates"][0]["sourceUri"] == "https://u"