Skip to content

Fix Terminal State Loss#1843

Merged
tom-ludwig merged 5 commits into
CodeEditApp:mainfrom
thecoolwinter:fix/terminal-state-loss
Aug 25, 2024
Merged

Fix Terminal State Loss#1843
tom-ludwig merged 5 commits into
CodeEditApp:mainfrom
thecoolwinter:fix/terminal-state-loss

Conversation

@thecoolwinter

@thecoolwinter thecoolwinter commented Aug 8, 2024

Copy link
Copy Markdown
Collaborator

Description

  • Fixes terminals losing their state when focus is changed away from them.
  • Pins a version of SwiftTerm with changes including:
  • Fixes the trash button in the terminals.
  • Removes a little bit of extra padding from the top of the terminal view.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-08-19.at.3.58.44.PM.mov

@austincondiff

Copy link
Copy Markdown
Collaborator

Did the sidebar expand like that before when changing selection?

@thecoolwinter thecoolwinter added the enhancement New feature or request label Aug 23, 2024

@tom-ludwig tom-ludwig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small tweak needed

Comment thread CodeEdit/Features/UtilityArea/TerminalUtility/UtilityAreaTerminalView.swift Outdated
@tom-ludwig tom-ludwig enabled auto-merge (squash) August 25, 2024 14:55
Comment thread CodeEdit/Features/TerminalEmulator/Model/TerminalCache.swift

@austincondiff austincondiff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Terminal is really shaping up

@tom-ludwig tom-ludwig merged commit 0bf177f into CodeEditApp:main Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request terminal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Clear terminal output 🐞 Fira Code is not work well in terminal 🐞 Terminal State is not saved when switching tabs

4 participants