chore: secret-scan + dev-scratch hygiene - #266
Merged
Merged
Conversation
- Add gitleaks workflow alongside GitHub's built-in Secret Scanning (already enabled). Pre-commit-shaped defence: any push or PR that introduces a string matching one of the ~150 default detectors will fail CI before it can merge. - Swap the hardcoded LXC IP in deploy/erp-deploy.json for the existing `erp-lxc` SSH-config alias. Same data, but the homelab address no longer ships in the public repo. README already documents the alias as a prerequisite. - Gitignore factory_state.json (planner scratch snapshot — carries a Steam ID and a local save path; never meant to be committed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The alias was already listed as a prerequisite, but never shown. A fresh dev box (e.g. macOS) hits a "Could not resolve hostname erp-lxc" footgun without it, now that the IP itself is gone from the committed config. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small repo-hygiene fixes after the post-merge secret audit on #265.
deploy/erp-deploy.jsonHost: `10.10.107.175` → `erp-lxc`. The committed config now references the SSH-config alias the README already requires (line 27), so the homelab IP no longer ships in the public repo. Code-side already supports this —RemoteOptions.Hostaccepts an alias OR a raw hostname (resolves via `ssh -G`).Test plan
🤖 Generated with Claude Code