Skip to content

Use checked-in keys for browser examples#62

Merged
tolgahan-arikan merged 3 commits into
masterfrom
hardcode-example-development-key
Jul 15, 2026
Merged

Use checked-in keys for browser examples#62
tolgahan-arikan merged 3 commits into
masterfrom
hardcode-example-development-key

Conversation

@tolgahan-arikan

@tolgahan-arikan tolgahan-arikan commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • use the Development sandbox publishable key directly in the custom Google redirect, Wagmi, and Trails Actions examples
  • use the existing Trails API key directly in the Wagmi example
  • remove obsolete browser-example env files, declarations, setup instructions, verification fallbacks, and GitHub Pages secret injection

Verification

  • pnpm verify
  • git diff --check

@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Claude finished @tolgahan-arikan's task —— View job


PR Review: Use checked-in keys for deployed examples

  • Read changed example config & env declaration files
  • Check for newly committed secrets/credentials
  • Verify no SDK behavior changes (auth/signing/tx/indexer)
  • Verify API.md / type-tests impact
  • Check .js import extension rule (src/)
  • Assess TypeScript soundness
  • Post review

Overall this is a clean, well-scoped change. It only touches the four browser examples' config/docs plus the Pages workflow and AGENTS.md — no src/ SDK code is affected. The approach matches the existing React example pattern (examples/react/src/config.ts:10 already checks in the same Development key), so it's internally consistent. AGENTS.md and the READMEs are updated in step with the code, satisfying the Maintenance Matrix.

Against the requested review focus

  • SDK behavior (auth/signing/tx/indexer): No changes. Nothing under src/ is modified; only example wiring. ✅
  • Test coverage: No SDK behavior changed, so no new tests are expected. The removed requiredEnv guards were example-only convenience checks, not covered by the SDK suite. ✅
  • API.md / type-tests: Not impacted — public export surface is unchanged. ✅
  • .js import extensions in src/: Rule not exercised; no src/ files touched. ✅
  • No new secrets: See note below. These are sandbox/Development-tier keys, consistent with the already-checked-in React key, so this is intentional per AGENTS.md. ✅ (with confirmation requested)
  • TypeScript soundness: No unsafe casts. One minor type-narrowing observation below. ✅

Observations (non-blocking)

  1. TRAILS_API_KEY is now always truthy — dead conditional.
    examples/wagmi/src/config.ts:2 now exports a non-empty string literal, but examples/wagmi/src/App.tsx:556 still branches on {TRAILS_API_KEY ? (...) : ...}. Previously the value came from import.meta.env.VITE_TRAILS_API_KEY and could be undefined, so the guard was meaningful. Now the type is string (a literal) and the else branch is unreachable. Not a bug, but you could simplify by dropping the conditional, or keep it if you want to preserve the fallback UI for local overrides. Purely optional.

  2. Confirm these are non-sensitive sandbox keys. The PR commits:

    • PUBLISHABLE_KEY = 'pk_dev_sdbx_...' — a pk_dev_sdbx (development sandbox) publishable key. Publishable keys are client-exposed by design, and this exact value is already checked into examples/react/src/config.ts, so this is fine.
    • TRAILS_API_KEY = 'AQAAAAAA...' (examples/wagmi/src/config.ts:2) — this one is worth an explicit confirmation: it's the "existing Trails API key" per the description and will be publicly readable in the deployed bundle. As long as it's a sandbox/public-tier Trails key scoped to the demo project (matching AGENTS.md's "checked-in Trails API key" note), this is consistent with the repo's stated approach. Flagging only so a maintainer confirms it isn't a privileged key.
  3. Doc/behavior consistency — good. AGENTS.md correctly drops the removed OMS_PUBLISHABLE_KEY / VITE_TRAILS_API_KEY Pages-secret guidance, and .github/workflows/pages.yml no longer injects those secrets. The three deleted .env.example files and the trimmed vite-env.d.ts reference-only files line up with the removed env reads. No dangling references to the removed env vars remain in the wagmi/trails-actions/react examples.

Verdict

Looks good to merge. The only actionable item is confirming the committed TRAILS_API_KEY is a public/sandbox-tier key (observation 2); the dead-conditional cleanup (observation 1) is optional polish.
• Branch: hardcode-example-development-key

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5717d7cfdf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread examples/wagmi/README.md
@tolgahan-arikan tolgahan-arikan changed the title Use checked-in keys for deployed examples Use checked-in keys for browser examples Jul 15, 2026
@tolgahan-arikan
tolgahan-arikan merged commit 9af9c38 into master Jul 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant